Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tests): clean up sample test tables #1030

Merged
merged 12 commits into from
Nov 11, 2024
Merged

chore(tests): clean up sample test tables #1030

merged 12 commits into from
Nov 11, 2024

Conversation

daniel-sanche
Copy link
Contributor

@daniel-sanche daniel-sanche commented Oct 25, 2024 •
edited
Loading

Currently, the sample tests are creating new tables for each test run, and not always cleaning them up properly. This causes tests to start failing when we hit the 1000 table per instance limit

This PR attempts to fix all the clean-up code to always run, even if there are errors in the tests. We do this using context managers and try/except statements

@daniel-sanche daniel-sanche requested review from a team as code owners October 25, 2024 20:58
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/python-bigtable API. samples Issues that are directly related to samples. labels Oct 25, 2024
@daniel-sanche daniel-sanche changed the title chore(tests): clean up sample test tables [DRAFT] chore(tests): clean up sample test tables Oct 25, 2024
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Oct 28, 2024
@daniel-sanche daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 29, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 29, 2024
@daniel-sanche daniel-sanche requested a review from a team as a code owner October 29, 2024 22:08
@daniel-sanche daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 30, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 30, 2024
@daniel-sanche daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 31, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 31, 2024
@daniel-sanche daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 4, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 4, 2024
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Nov 7, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 23 region tags.
You are about to delete 23 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot removed the size: l Pull request size is large. label Nov 7, 2024
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Nov 7, 2024
@daniel-sanche daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 8, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 8, 2024
@daniel-sanche daniel-sanche changed the title [DRAFT] chore(tests): clean up sample test tables chore(tests): clean up sample test tables Nov 8, 2024
@daniel-sanche daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 11, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 11, 2024
@daniel-sanche daniel-sanche merged commit d354349 into main Nov 11, 2024
29 of 32 checks passed
@daniel-sanche daniel-sanche deleted the cleanup_sample_tests branch November 11, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhshkh bhshkh bhshkh approved these changes

@msampathkumar msampathkumar Awaiting requested review from msampathkumar msampathkumar is a code owner automatically assigned from googleapis/python-samples-reviewers

Assignees

@sushanb sushanb

Labels
api: bigtable Issues related to the googleapis/python-bigtable API. samples Issues that are directly related to samples. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daniel-sanche @bhshkh @sushanb @yoshi-kokoro